Skip to content

Conversation

@lijinpei2008
Copy link
Contributor

@lijinpei2008 lijinpei2008 commented Aug 8, 2025

#28317

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

…owing cmdlet adds a BreakingChange announcement
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@lijinpei2008 lijinpei2008 added the Contains Breaking Change This PR contains breaking change label Aug 11, 2025
@lijinpei2008 lijinpei2008 marked this pull request as ready for review August 11, 2025 06:20
Copilot AI review requested due to automatic review settings August 11, 2025 06:20
@github-actions
Copy link

To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds breaking change announcements to the Az.HealthcareApis module to inform users of upcoming code base refactoring. The changes prepare for future modifications that will affect cmdlet parameters and output types.

  • Updates changelog to announce breaking changes for 15 healthcare cmdlets
  • Adds breaking change attributes to PowerShell cmdlet files for proper deprecation warnings
  • Updates module dependencies and configuration files for the refactoring

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/HealthcareApis/HealthcareApis/ChangeLog.md Adds comprehensive list of cmdlets that will have breaking changes
src/HealthcareApis/HealthcareApis/Az.HealthcareApis.psd1 Updates module dependency version and formatting configurations
src/HealthcareApis/HealthcareApis.sln Restructures solution file with new project configurations
src/HealthcareApis/HealthcareApis.Autorest/README.md Adds breaking change configuration directives for autorest generation
Multiple cmdlet files Adds breaking change attributes to New-Az* cmdlets for proper deprecation notices
Various support files Updates generated files and documentation with new GUIDs and assembly info

- CorConfigurationHeader
- IdentityType
- IdentityUserAssignedIdentity
change-description: (1)The types of the properties 'PrivateEndpointConnection' and 'AuthenticationConfigurationAudience' will be changed from single object to 'List'. (2)IdentityType will be removed. EnableSystemAssignedIdentity will be used to enable/disable system assigned identity and UserAssignedIdentity will be used to specify user assigned identities.
Copy link

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'AuthenticationConfigurationAudience' is mentioned in the change description for FhirService but this property is not listed in the deprecated-output-properties or new-output-properties sections above. This appears to be copied from the DicomService section where this property is relevant.

Suggested change
change-description: (1)The types of the properties 'PrivateEndpointConnection' and 'AuthenticationConfigurationAudience' will be changed from single object to 'List'. (2)IdentityType will be removed. EnableSystemAssignedIdentity will be used to enable/disable system assigned identity and UserAssignedIdentity will be used to specify user assigned identities.
change-description: (1)The type of the property 'PrivateEndpointConnection' will be changed from single object to 'List'. (2)IdentityType will be removed. EnableSystemAssignedIdentity will be used to enable/disable system assigned identity and UserAssignedIdentity will be used to specify user assigned identities.

Copilot uses AI. Check for mistakes.
@lijinpei2008 lijinpei2008 removed the Contains Breaking Change This PR contains breaking change label Aug 18, 2025
NoriZC
NoriZC previously approved these changes Aug 18, 2025
Comment on lines 21 to 36
* The code base is going to be refactored, the following cmdlet adds a BreakingChange announcement:
* `Get-AzHealthcareApisService`
* `New-AzHealthcareApisService`
* `Update-AzHealthcareApisService`
* `Get-AzHealthcareApisWorkspace`
* `New-AzHealthcareApisWorkspace`
* `Update-AzHealthcareApisWorkspace`
* `Get-AzHealthcareDicomService`
* `New-AzHealthcareDicomService`
* `Update-AzHealthcareDicomService`
* `Get-AzHealthcareFhirService`
* `New-AzHealthcareFhirService`
* `Update-AzHealthcareFhirService`
* `New-AzHealthcareIotConnector`
* `Test-AzHealthcareServiceNameAvailability`
* `Update-AzHealthcareIotConnector`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The code base is going to be refactored, the following cmdlet adds a BreakingChange announcement:
* `Get-AzHealthcareApisService`
* `New-AzHealthcareApisService`
* `Update-AzHealthcareApisService`
* `Get-AzHealthcareApisWorkspace`
* `New-AzHealthcareApisWorkspace`
* `Update-AzHealthcareApisWorkspace`
* `Get-AzHealthcareDicomService`
* `New-AzHealthcareDicomService`
* `Update-AzHealthcareDicomService`
* `Get-AzHealthcareFhirService`
* `New-AzHealthcareFhirService`
* `Update-AzHealthcareFhirService`
* `New-AzHealthcareIotConnector`
* `Test-AzHealthcareServiceNameAvailability`
* `Update-AzHealthcareIotConnector`
* Added BreakingChange announcements for commands below:
- `Get-AzHealthcareApisService`
- `New-AzHealthcareApisService`
- `Update-AzHealthcareApisService`
- `Get-AzHealthcareApisWorkspace`
- `New-AzHealthcareApisWorkspace`
- `Update-AzHealthcareApisWorkspace`
- `Get-AzHealthcareDicomService`
- `New-AzHealthcareDicomService`
- `Update-AzHealthcareDicomService`
- `Get-AzHealthcareFhirService`
- `New-AzHealthcareFhirService`
- `Update-AzHealthcareFhirService`
- `New-AzHealthcareIotConnector`
- `Test-AzHealthcareServiceNameAvailability`
- `Update-AzHealthcareIotConnector`

@NoriZC NoriZC dismissed their stale review August 18, 2025 06:48

Please update the changelog :)

@lijinpei2008 lijinpei2008 added the Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change label Aug 18, 2025
@NoriZC NoriZC merged commit 9b06438 into main Aug 19, 2025
12 checks passed
@NoriZC NoriZC deleted the jinpei/main/HealthcareApis-Announcement branch August 19, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants